-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
PyUnstable_GC_VisitObjects should traverse the permanent generation as well #131740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
interpreter-core
(Objects, Python, Grammar, and Parser dirs)
topic-C-API
type-bug
An unexpected behavior, bug, or error
Comments
corona10
added a commit
to corona10/cpython
that referenced
this issue
Mar 25, 2025
corona10
added a commit
to corona10/cpython
that referenced
this issue
Mar 25, 2025
@corona10 I work on cinder too; the current implementation is causing us some issues, so I figured we would add the fix upstream first and then backport it. thanks for doing the fix already :) |
corona10
added a commit
that referenced
this issue
Mar 26, 2025
corona10
added a commit
to corona10/cpython
that referenced
this issue
Mar 26, 2025
… perm gen (pythongh-131744) (cherry picked from commit 7bb41ae)
corona10
added a commit
that referenced
this issue
Mar 26, 2025
corona10
added a commit
to corona10/cpython
that referenced
this issue
Mar 28, 2025
corona10
added a commit
to corona10/cpython
that referenced
this issue
Mar 28, 2025
corona10
added a commit
to corona10/cpython
that referenced
this issue
Mar 28, 2025
pablogsal
pushed a commit
that referenced
this issue
Mar 28, 2025
corona10
pushed a commit
that referenced
this issue
Mar 28, 2025
…1786) Minor readability fix in PyUnstable_GC_VisitObjects Replaces `if (visit_generation())` with `if (visit_generation() < 0)`, since we are checking for the failure case, and it's confusing to have that be implicitly `true`. Also fixes a misspelt variable name.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this issue
Apr 1, 2025
seehwan
pushed a commit
to seehwan/cpython
that referenced
this issue
Apr 16, 2025
seehwan
pushed a commit
to seehwan/cpython
that referenced
this issue
Apr 16, 2025
…ythongh-131786) Minor readability fix in PyUnstable_GC_VisitObjects Replaces `if (visit_generation())` with `if (visit_generation() < 0)`, since we are checking for the failure case, and it's confusing to have that be implicitly `true`. Also fixes a misspelt variable name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
interpreter-core
(Objects, Python, Grammar, and Parser dirs)
topic-C-API
type-bug
An unexpected behavior, bug, or error
Bug report
Bug description:
This function is meant to walk the heap and visit all GCable objects. It currently ignores the permanent / frozen generation, which is a problem when calling code expects to get all extant objects.
As a concrete example, the cinder JIT compiler uses this function to scan through all Python functions on the heap and try JIT compiling them. Functions that have been frozen by
gc.freeze()
orimmortalize_heap()
are not processed, and thus do not get compiled.CPython versions tested on:
3.12
Operating systems tested on:
Linux
Linked PRs
The text was updated successfully, but these errors were encountered: