Inconsistency in json.JSONEncoder Description Regarding skipkeys Behavior

[mouchen626]

If skipkeys is false (the default), a TypeError will be raised when trying to encode keys that are not str, int, float or None. If skipkeys is true, such items are simply skipped.

However, boolean values (True and False) can be used as dictionary keys without raising a TypeError. I think this is a mistake.

json.JSONEncoder(skipkeys=False).encode({True:1})

Linked PRs

• gh-132021: Add bool type to the list of types that were allowed in keys of encode(...) method #132048

[ericvsmith]

bools are ints, so the statement is technically true.

>>> isinstance(True, int)
True
>>> isinstance(False, int)
True

Although maybe it makes sense to add bool to the list of types.

[mouchen626]

Thank you, I understand. I noticed that the description of json.dump includes bool. It would be better to keep it consistent.

skipkeys (bool) – If True, keys that are not of a basic type (str, int, float, bool, None) will be skipped instead of raising a TypeError. Default False.

[brianschubert]

Seems good - would you like to put up a PR?