Skip to content

Enable type checking of tomllib stdlib folder #133117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sobolevn opened this issue Apr 28, 2025 · 2 comments
Open

Enable type checking of tomllib stdlib folder #133117

sobolevn opened this issue Apr 28, 2025 · 2 comments
Assignees
@sobolevn
Labels
build The build process and cross-build stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@sobolevn
Copy link
Member

sobolevn commented Apr 28, 2025 •
edited by bedevere-app bot
Loading

Following example of #131509 I propose to add mypy type checking in CI for tomllib.

It is fully typed already, we just need to run the CI if something changes.

Linked PRs
@sobolevn sobolevn added build The build process and cross-build stdlib Python modules in the Lib dir labels Apr 28, 2025
@sobolevn sobolevn self-assigned this Apr 28, 2025
sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 28, 2025
@sobolevn
pythongh-133117: Run mypy on tomllib in CI
1fcd462
sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 28, 2025
@sobolevn
pythongh-133117: Run mypy on tomllib in CI
4c8738f
@bedevere-app bedevere-app bot mentioned this issue Apr 28, 2025
Merged
@AA-Turner
Copy link
Member

cc @hukkin.

See also discussion in #128907 re possibly removing annotations from tomllib in the future (post 3.10 EOL) for performance/etc. Given that's a way off though, running mypy may be pragmatic in the meantime.

A

sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 29, 2025
@sobolevn
pythongh-133117: Run mypy on tomllib in CI
3eec25a
@hukkin
Copy link
Contributor

hukkin commented Apr 29, 2025

I fully support this.

sobolevn added a commit that referenced this issue Apr 30, 2025
@sobolevn
gh-133117: Run mypy on tomllib in CI (#133118)
5ea9010
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 30, 2025
@sobolevn @miss-islington
pythongh-133117: Run mypy on tomllib in CI (pythonGH-133118)
b9259e1 
(cherry picked from commit 5ea9010)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Apr 30, 2025
Merged
sobolevn added a commit that referenced this issue Apr 30, 2025
@miss-islington @sobolevn
[3.13] gh-133117: Run mypy on tomllib in CI (GH-133118) (#133192)
0458554 
gh-133117: Run mypy on `tomllib` in CI (GH-133118)
(cherry picked from commit 5ea9010)

Co-authored-by: sobolevn <[email protected]>
sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 30, 2025
@sobolevn
pythongh-133117: Enable stricter mypy checks for tomllib
bdf615d
@bedevere-app bedevere-app bot mentioned this issue Apr 30, 2025
Open
@picnixz picnixz added the type-feature A feature request or enhancement label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
build The build process and cross-build stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hukkin @sobolevn @AA-Turner @picnixz