Skip to content

Data races in typeobject.c for type structure updates #133467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nascheme opened this issue May 5, 2025 · 0 comments
Open

Data races in typeobject.c for type structure updates #133467

nascheme opened this issue May 5, 2025 · 0 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-free-threading type-bug An unexpected behavior, bug, or error

Comments

@nascheme
Copy link
Member

nascheme commented May 5, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

There are some additional data races (producing TSAN warnings) for typeobject.c in the free-threaded build.

The following stores are unsafe:

  • _Py_slot_tp_getattr_hook re-assigns tp_getattro
  • slot_tp_descr_get assigns to tp_descr_get
  • type_set_name assigns to tp_name
  • tp_base and tp_bases are assigned in likely unsafe ways

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@nascheme nascheme added the type-bug An unexpected behavior, bug, or error label May 5, 2025
@nascheme nascheme mentioned this issue May 5, 2025
Merged
@bedevere-app bedevere-app bot mentioned this issue May 6, 2025
Merged
@picnixz picnixz added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label May 7, 2025
nascheme added a commit to nascheme/cpython that referenced this issue May 8, 2025
@nascheme
Merge branch 'main' into pythongh-133467-typeobject-tsan-suppress
62c4ce3
nascheme added a commit that referenced this issue May 8, 2025
@nascheme
gh-133467: Add TSAN suppressions for races in typeobject (gh-133534)
8679c8d
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 8, 2025
@nascheme @miss-islington
pythongh-133467: Add TSAN suppressions for races in typeobject (pytho…
4e10033 
…ngh-133534)

(cherry picked from commit 8679c8d)

Co-authored-by: Neil Schemenauer <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue May 8, 2025
Merged
nascheme pushed a commit that referenced this issue May 8, 2025
@miss-islington
[3.14] gh-133467: Add TSAN suppressions for races in typeobject (gh-1…
4c6fa89 
…33534) (gh-133717)

(cherry picked from commit 8679c8d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-free-threading type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nascheme @picnixz