Skip to content

Possible memory leak on error path in _sys_getwindowsversion_from_kernel32 #133597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sergey-miryanov opened this issue May 7, 2025 · 0 comments
Closed

Possible memory leak on error path in _sys_getwindowsversion_from_kernel32 #133597

sergey-miryanov opened this issue May 7, 2025 · 0 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@sergey-miryanov
Copy link
Contributor

sergey-miryanov commented May 7, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

If GetFileVersionInfoW or VerQueryValueW fails inside _sys_getwindowsversion_from_kernel32 then allocated verblock not freed.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Windows

Linked PRs
@sergey-miryanov sergey-miryanov added the type-bug An unexpected behavior, bug, or error label May 7, 2025
@bedevere-app bedevere-app bot mentioned this issue May 7, 2025
Merged
@picnixz picnixz added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label May 7, 2025
zooba pushed a commit that referenced this issue May 8, 2025
@sergey-miryanov
gh-133597: Fix memory leak if error occurred in _sys_getwindowsversio…
0ec8fc8 
…n_from_kernel32 (GH-133598)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 8, 2025
@sergey-miryanov @miss-islington
pythongh-133597: Fix memory leak if error occurred in _sys_getwindows…
59e1366 
…version_from_kernel32 (pythonGH-133598)

(cherry picked from commit 0ec8fc8)

Co-authored-by: Sergey Miryanov <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue May 8, 2025
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 8, 2025
@sergey-miryanov @miss-islington
pythongh-133597: Fix memory leak if error occurred in _sys_getwindows…
a20ce09 
…version_from_kernel32 (pythonGH-133598)

(cherry picked from commit 0ec8fc8)

Co-authored-by: Sergey Miryanov <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue May 8, 2025
Merged
zooba pushed a commit that referenced this issue May 8, 2025
@miss-islington @sergey-miryanov
gh-133597: Fix memory leak if error occurred in _sys_getwindowsversio…
e0aefbd 
…n_from_kernel32 (GH-133598)

(cherry picked from commit 0ec8fc8)

Co-authored-by: Sergey Miryanov <[email protected]>
@zooba zooba closed this as completed May 8, 2025
zooba pushed a commit that referenced this issue May 8, 2025
@miss-islington @sergey-miryanov
gh-133597: Fix memory leak if error occurred in _sys_getwindowsversio…
caeb422 
…n_from_kernel32 (GH-133598)

(cherry picked from commit 0ec8fc8)

Co-authored-by: Sergey Miryanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sergey-miryanov @zooba @picnixz