Skip to content

remove non-ascii characters in docstring #80282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
animalize mannequin opened this issue Feb 24, 2019 · 8 comments
Closed

remove non-ascii characters in docstring #80282

animalize mannequin opened this issue Feb 24, 2019 · 8 comments
Labels
3.8 (EOL) end of life docs Documentation in the Doc dir

Comments

@animalize
Copy link
Mannequin

animalize mannequin commented Feb 24, 2019

BPO 36101
Nosy @methane, @animalize
PRs
  • bpo-36101: remove non-ascii characters in docstring #12018
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-02-24.23:20:06.313>
    created_at = <Date 2019-02-24.13:36:09.880>
    labels = ['3.8', 'docs']
    title = 'remove non-ascii characters in docstring'
    updated_at = <Date 2019-02-24.23:20:06.312>
    user = 'https://github.com/animalize'

    bugs.python.org fields:

    activity = <Date 2019-02-24.23:20:06.312>
    actor = 'methane'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2019-02-24.23:20:06.313>
    closer = 'methane'
    components = ['Documentation']
    creation = <Date 2019-02-24.13:36:09.880>
    creator = 'malin'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36101
    keywords = ['patch']
    message_count = 4.0
    messages = ['336468', '336469', '336488', '336489']
    nosy_count = 3.0
    nosy_names = ['methane', 'docs@python', 'malin']
    pr_nums = ['12018']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue36101'
    versions = ['Python 3.8']

    Linked PRs

    @animalize
    Copy link
    Mannequin Author

    animalize mannequin commented Feb 24, 2019

    replace ’(\u2019) with '(\x27)

    @animalize animalize mannequin added 3.7 (EOL) end of life 3.8 (EOL) end of life labels Feb 24, 2019
    @animalize animalize mannequin assigned docspython Feb 24, 2019
    @animalize animalize mannequin added the docs Documentation in the Doc dir label Feb 24, 2019
    @animalize
    Copy link
    Mannequin Author

    animalize mannequin commented Feb 24, 2019

    only 3.8 branch has those non-ascii characters.

    @animalize animalize mannequin removed the 3.7 (EOL) end of life label Feb 24, 2019
    @methane
    Copy link
    Member

    methane commented Feb 24, 2019

    New changeset 463572c by Inada Naoki (animalize) in branch 'master':
    bpo-36101: remove non-ascii characters in docstring (GH-12018)
    463572c

    @methane
    Copy link
    Member

    methane commented Feb 24, 2019

    thanks

    @erlend-aasland
    Copy link
    Contributor

    @methane, @animalize: why was this limitation introduced? I find no rationale or motivation in this issue, nor on the PR.

    cc. @AlexWaygood & @terryjreedy

    @methane
    Copy link
    Member

    methane commented Aug 2, 2023

    Sorry, I don't remember where we discussed.
    When this change was made, MSVC used ANSI Codepage for C sources.

    Now we use /utf8 flag on MSVC. So that limitation has been removed.
    But I am still not sure that the C source is 100% UTF-8 on all platform and compiler toolsets.

    @erlend-aasland
    Copy link
    Contributor

    Thank you, Inada-san! I suspected it had to do with Windows. Perhaps someone on the @python/windows-team could chime in, regarding status quo today? Is this limitation still needed?

    @methane
    Copy link
    Member

    methane commented Aug 3, 2023

    There are platforms we don't support officially but some active users maintain Python running.
    Solaris and AIX.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 (EOL) end of life docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants