Skip to content

test_invalid_utf8 test failing on some buildbots #96189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdboom opened this issue Aug 22, 2022 · 1 comment
Closed

test_invalid_utf8 test failing on some buildbots #96189

mdboom opened this issue Aug 22, 2022 · 1 comment
Labels
type-bug An unexpected behavior, bug, or error

Comments

@mdboom
Copy link
Contributor

mdboom commented Aug 22, 2022

The test added in #94856 is failing on a number of buildbots:
@mdboom mdboom added the type-bug An unexpected behavior, bug, or error label Aug 22, 2022
@bedevere-bot bedevere-bot mentioned this issue Aug 22, 2022
Merged
mdboom added a commit to mdboom/cpython that referenced this issue Aug 22, 2022
@mdboom
pythongh-96189: Fix test_invalid_utf8 on a number of build bots
cd9b0f5 
The clearing of the temporary directory is not working on some platforms and
leaving behind files.

This has been updated to use the pattern in test_cmd_line.py [1] using the
special TESTFN rather than a test directory.

[1] https://github.com/python/cpython/blob/main/Lib/test/test_cmd_line.py#L559
@bedevere-bot bedevere-bot mentioned this issue Aug 23, 2022
Merged
miss-islington pushed a commit that referenced this issue Aug 23, 2022
@mdboom
gh-96189: Fix test_invalid_utf8 on a number of build bots (GH-96190)
054328f 
The clearing of the temporary directory is not working on some platforms and
leaving behind files.

This has been updated to use the pattern in test_cmd_line.py [1] using the
special TESTFN rather than a test directory.

[1] https://github.com/python/cpython/blob/main/Lib/test/test_cmd_line.py#L559
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 23, 2022
@mdboom @miss-islington
pythongh-96189: Fix test_invalid_utf8 on a number of build bots (pyth…
3f2eace 
…onGH-96190)

The clearing of the temporary directory is not working on some platforms and
leaving behind files.

This has been updated to use the pattern in test_cmd_line.py [1] using the
special TESTFN rather than a test directory.

[1] https://github.com/python/cpython/blob/main/Lib/test/test_cmd_line.pyGH-L559
(cherry picked from commit 054328f)

Co-authored-by: Michael Droettboom <[email protected]>
pablogsal pushed a commit that referenced this issue Aug 23, 2022
@miss-islington @mdboom
[3.11] gh-96189: Fix test_invalid_utf8 on a number of build bots (GH-…
c01fc9d 
…96190) (#96218)

Co-authored-by: Michael Droettboom <[email protected]>
mdboom added a commit to mdboom/cpython that referenced this issue Aug 24, 2022
@mdboom
pythongh-96189: Fix test_invalid_utf8 on a number of build bots (pyth…
15814e1 
…onGH-96190)

The clearing of the temporary directory is not working on some platforms and
leaving behind files.

This has been updated to use the pattern in test_cmd_line.py [1] using the
special TESTFN rather than a test directory.

[1] https://github.com/python/cpython/blob/main/Lib/test/test_cmd_line.py#L559
@hauntsaninja
Copy link
Contributor

Thanks for fixing, looks like this has been completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdboom @hauntsaninja