Skip to content

gh-100792: Make email.message.Message.__contains__ twice as fast #100793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2023
Merged

gh-100792: Make email.message.Message.__contains__ twice as fast #100793

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe61248
gh-100792: Make `email.message.Message.__contains__` twice as fast
sobolevn Jan 6, 2023
d2d0c76
Update Misc/NEWS.d/next/Library/2023-01-06-14-05-15.gh-issue-100792.C…
sobolevn Jan 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Lib/email/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,11 @@ def __delitem__(self, name):
self._headers = newheaders

def __contains__(self, name):
return name.lower() in [k.lower() for k, v in self._headers]
name_lower = name.lower()
for k, v in self._headers:
if name_lower == k.lower():
return True
return False

def __iter__(self):
for field, value in self._headers:
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2023-01-06-14-05-15.gh-issue-100792.CEOJth.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make ``email.message.Message.__contains__`` twice as fast.