gh-100762: Switch order of exception match in gen_close #101011
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the closing of generators by switching the match statements in the expression
PyErr_ExceptionMatches(PyExc_StopIteration) || PyErr_ExceptionMatches(PyExc_GeneratorExit)
from thegen_close
method. The case of aPyExc_GeneratorExit
is more common.Benchmark (with optimizations including PGO) updated May 9th:
Benchmark script:
Notes:
PyExc_StopIteration
is triggered occur less than thePyExc_GeneratorExit
. Cases from the python test suite aretest_async_gen_asyncio_aclose_10
intest_asyncgen.py
and the following code fromtest_generators.py
: