Skip to content

gh-101549: fix documentation of xml.etree.ElementInclude #101550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 11, 2024

Conversation

mbel0
Copy link
Contributor

@mbel0 mbel0 commented Feb 3, 2023

fixed wrong type in default_loader description. fixed description of the include method.

@ghost
Copy link

ghost commented Feb 3, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@mbel0 mbel0 force-pushed the fix-issue-101549 branch 2 times, most recently from c6f50f5 to dba777c Compare February 3, 2023 23:40
fixed wrong type in default_loader description. fixed description of the
include method.
@AA-Turner AA-Turner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 12, 2024
@AA-Turner AA-Turner enabled auto-merge (squash) January 12, 2024 23:33
@AlexWaygood AlexWaygood disabled auto-merge February 21, 2024 10:50
mbel0 and others added 5 commits February 21, 2024 10:38
@mbel0
Copy link
Contributor Author

mbel0 commented Feb 21, 2024

@AA-Turner , I updated class references introduced by you: short name can't be used as ElementInclude documentation is configured in another module, so full names has to be used.

I also removed hacks introduced in #31615 : as module now is configured there is no need to add separate ":module:" and no need to specify full path to function inside a module

now all documentation checks are passed. please let me know if I need to change anything else in the review

@hugovk hugovk removed the needs backport to 3.11 only security fixes label Apr 11, 2024
@hugovk hugovk enabled auto-merge (squash) April 11, 2024 14:23
@hugovk hugovk merged commit 898f6de into python:main Apr 11, 2024
1 check passed
@miss-islington-app
Copy link

Thanks @mbel0 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 11, 2024
…nGH-101550)

(cherry picked from commit 898f6de)

Co-authored-by: Mikhail B <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 11, 2024

GH-117754 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 11, 2024
hugovk pushed a commit that referenced this pull request Apr 11, 2024
…01550) (#117754)

Co-authored-by: Mikhail B <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news topic-XML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants