-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-101640: Make argparse working in pythonw
by dropping stderr writes there
#101802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ping? |
pythonw
by dropping stderr writes there
ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure who you are pinging, but... tests look OK to me. I just suggest catching any write error.
Misc/NEWS.d/next/Library/2023-02-09-22-24-34.gh-issue-101640.oFuEpB.rst
Outdated
Show resolved
Hide resolved
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Terry Jan Reedy <[email protected]>
Retriggering the build to restart the failed
|
The docs deploy continues to fail. However, this PR doesn't change documentation so I believe it can be ignored for now. For Bedevere: I have made the requested changes; please review again. |
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
Thanks @arhadthedev for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-104250 is a backport of this pull request to the 3.11 branch. |
…ythonGH-101802) * In particular, don't exit when trying to print to stderr = None. * Add tests (cherry picked from commit 42f54d1) Co-authored-by: Oleg Iarygin <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
…H-101802) (#104250) gh-101640: Make argparse _print_message catch any write error (GH-101802) * In particular, don't exit when trying to print to stderr = None. * Add tests (cherry picked from commit 42f54d1) Co-authored-by: Oleg Iarygin <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
…ython#101802) * In particular, don't exit when trying to print to stderr = None. * Add tests Co-authored-by: Terry Jan Reedy <[email protected]>
A note on freshly added tests:
StdStreamTest.test_skip_invalid_stderr()
is confirmed to be failing before the patchStdStreamTest.test_skip_invalid_stdout()
is added for symmetry; its tested behavior already worked correctly