[3.11] gh-101857: Allow xattr detection on musl libc (GH-101858) #101894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we checked exclusively for `__GLIBC__` (AND'd with some other conditions). Checking for `__linux__` instead should be fine. This fixes using e.g. `os.listxattr()` on systems using musl libc. Bug: https://bugs.gentoo.org/894130 (cherry picked from commit 8be8101) Co-authored-by: Sam James <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]>
This was referenced Feb 14, 2023
|
Waiting for the buildbot results on the main branch commit before merging this just in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we checked exclusively for
__GLIBC__(AND'd with some otherconditions). Checking for
__linux__instead should be fine.This fixes using e.g.
os.listxattr()on systems using musl libc.Bug: https://bugs.gentoo.org/894130
(cherry picked from commit 8be8101)
Co-authored-by: Sam James [email protected]
Co-authored-by: Gregory P. Smith [email protected]
posixmodule.cdoesn't detect xattr support on Linux with non-glibc (e.g. musl) #101857