-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
[doc] Fix error in tutorial example: type(exc) is the type rather than the instance #102751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
However, printing type
of exception which we catching, looks kinda weird. This always will be <class Exception>
, but it's tutorial example, so that's ok.
Thanks @jenshb for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, @jenshb and @iritkatriel, I could not cleanly backport this to |
GH-102928 is a backport of this pull request to the 3.11 branch. |
…n the instance (pythonGH-102751) (cherry picked from commit 8709697) Co-authored-by: Jens-Hilmar Bradt <[email protected]>
…n the instance (GH-102751) (cherry picked from commit 8709697) Co-authored-by: Jens-Hilmar Bradt <[email protected]>
No description provided.