gh-102823: Document return type of floor division on floats #102824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclips4
reviewed
Mar 19, 2023
skirpichev
reviewed
Mar 20, 2023
skirpichev
reviewed
Mar 20, 2023
skirpichev
approved these changes
Mar 20, 2023
Eclips4
approved these changes
Mar 20, 2023
hugovk
reviewed
Sep 7, 2023
hugovk
added
needs backport to 3.11
|
Thanks @mdickinson for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2023
…thonGH-102824) (cherry picked from commit b72251d) Co-authored-by: Mark Dickinson <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
GH-109092 is a backport of this pull request to the 3.12 branch. |
|
GH-109093 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2023
…thonGH-102824) (cherry picked from commit b72251d) Co-authored-by: Mark Dickinson <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
added a commit
that referenced
this pull request
Sep 7, 2023
…H-102824) (#109093) Co-authored-by: Mark Dickinson <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Sep 8, 2023
…H-102824) (#109092) gh-102823: Document return type of floor division on floats (GH-102824) (cherry picked from commit b72251d) Co-authored-by: Mark Dickinson <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents the long-standing behaviour that the floor division operator
//applied tofloatoperands returns a result of typefloat.Also adds a missing note to the table to note that
x // yisn't valid for complex numbers.