-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-87864: Use correct function definition syntax in the docs #103312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharel
approved these changes
Apr 8, 2023
@hugovk can you please take a look when you have the time? |
hugovk
approved these changes
Apr 11, 2023
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 11, 2023
…ythonGH-103312) (cherry picked from commit 50b4b15) Co-authored-by: Nikita Sobolev <[email protected]>
GH-103442 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
Apr 11, 2023
(cherry picked from commit 50b4b15) Co-authored-by: Nikita Sobolev <[email protected]>
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed
...
in the parameter list of function definitions to beargN
or similar.It looks to me as it is a better thing to do: while we keep the same (or even clearer semantics), we also use the correct python syntax to do it.