Skip to content

GH-83893: Cross reference env. vars and -X command line options #103414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 12, 2023

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Apr 10, 2023

Co-authored-by: Erlend E. Aasland

@erlend-aasland erlend-aasland added the needs backport to 3.11 only security fixes label Apr 10, 2023
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standard reminder: You can directly apply all the suggestions you want in one go by going to Files changed -> Clicking Add to batch on each suggestion -> When done, clicking Commit

One suggestion, aside from those @erlend-aasland already made.

Just to note, the docs build error is unrelated and will be fixed by #103421

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me; thanks @furkanonder

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for picking this up, Furkan!

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit d65ed69 into python:main Apr 12, 2023
@miss-islington
Copy link
Contributor

Thanks @furkanonder for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 12, 2023
…pythonGH-103414)

(cherry picked from commit d65ed69)

Co-authored-by: Furkan Onder <[email protected]>
Co-authored-by: Erlend E. Aasland
@bedevere-bot
Copy link

GH-103467 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 12, 2023
miss-islington added a commit that referenced this pull request Apr 16, 2023
…03414)

(cherry picked from commit d65ed69)

Co-authored-by: Furkan Onder <[email protected]>
Co-authored-by: Erlend E. Aasland
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants