-
-
Notifications
You must be signed in to change notification settings - Fork 32k
GH-69695: Update PyImport_ImportModule
description
#103836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PyImport_ImportModule
description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new lines are too long; I suspect Adam's line wrapping suggestions should fix the issue.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Adam Turner <[email protected]>
I have made the requested changes; please review again. (I wonder if this works if I'm not the PR author.) |
It doesn't work for anybody right now: |
…H-103836) (cherry picked from commit 9872855) Co-authored-by: patenaud <[email protected]> Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Adam Turner <[email protected]>
GH-114924 is a backport of this pull request to the 3.11 branch. |
…H-103836) (cherry picked from commit 9872855) Co-authored-by: patenaud <[email protected]> Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Adam Turner <[email protected]>
…H-103836) (cherry picked from commit 9872855) Co-authored-by: patenaud <[email protected]> Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Adam Turner <[email protected]>
GH-114925 is a backport of this pull request to the 3.12 branch. |
) (GH-114924) GH-69695: Update ``PyImport_ImportModule`` description (GH-103836) (cherry picked from commit 9872855) Co-authored-by: patenaud <[email protected]> Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Adam Turner <[email protected]>
) GH-114925) GH-69695: Update ``PyImport_ImportModule`` description (GH-103836) (cherry picked from commit 9872855) Co-authored-by: patenaud <[email protected]> Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Adam Turner <[email protected]>
…H-103836) Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Adam Turner <[email protected]>
…H-103836) Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Adam Turner <[email protected]>
import.rst file updated
gh-69695: PyImport_ImportModule description updated