Skip to content

[3.11] gh-103606: Improve error message from logging.config.FileConfig (GH-103628) #104687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2023

Conversation

Agent-Hellboy
Copy link
Contributor

@Agent-Hellboy Agent-Hellboy commented May 20, 2023

Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't merge this in 3.11 yet, there are some things to cleanup in main from the original PR first.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Agent-Hellboy
Copy link
Contributor Author

Agent-Hellboy commented May 20, 2023

I wouldn't merge this in 3.11 yet, there are some things to cleanup in main from the original PR first.

saw your comments, I will clean it

@Agent-Hellboy
Copy link
Contributor Author

Agent-Hellboy commented May 20, 2023

Hi @gpshead I have added a PR, #104701

@gpshead
Copy link
Member

gpshead commented May 20, 2023

Hi @gpshead I have added a PR, #104701

merged. feel free to just apply those edits to this PR as the backport.

@Agent-Hellboy
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@gpshead: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from gpshead May 21, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants