gh-49174: document that the effect of calling gc.collect() during a collection is undefined #104699
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng a collection is undefined
gpshead
approved these changes
May 20, 2023
iritkatriel
commented
May 20, 2023
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-104703 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2023
…ng a collection is undefined (pythonGH-104699) (cherry picked from commit 30488fa) Co-authored-by: Irit Katriel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49174.
As discussed in the issue, currently gc.collect() during a collection is ignored (even if its specifies more generations than the ongoing collection). But I don't think we should enshrine this in the docs, so I propose to say it's undefined.
📚 Documentation preview 📚: https://cpython-previews--104699.org.readthedocs.build/