Skip to content

gh-106656: Remove --emit-line-directives from regen-cases #106657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Jul 12, 2023

If you prefer to see #line directives in generated_cases.c.h, run make regen-cases CASESFLAG=-l. But please don't commit the result.

If you prefer to see #line directives in generated_cases.c.h,
run `make regen-cases -l`. But please don't commit the result.
@gvanrossum
Copy link
Member Author

I plan to merge this later today, after fixing the merge conflict.

@gvanrossum gvanrossum enabled auto-merge (squash) July 12, 2023 15:41
@gvanrossum
Copy link
Member Author

(A side effect will also be fewer merge conflicts on the generated files.)

@gvanrossum gvanrossum linked an issue Jul 12, 2023 that may be closed by this pull request
@gvanrossum gvanrossum merged commit 7f55f58 into python:main Jul 12, 2023
@gvanrossum gvanrossum deleted the rm-line-dirs branch July 12, 2023 16:18
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x has failed when building commit 7f55f58.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/4419) and take a look at the build logs.
  4. Check if the failure is related to this commit (7f55f58) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/4419

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

426 tests OK.

10 slowest tests:

  • test_venv: 8 min 20 sec
  • test_largefile: 7 min 44 sec
  • test_math: 4 min 31 sec
  • test_signal: 4 min 13 sec
  • test_multiprocessing_spawn: 3 min 45 sec
  • test_mailbox: 3 min 42 sec
  • test_concurrent_futures: 3 min 28 sec
  • test_multiprocessing_forkserver: 2 min 30 sec
  • test_hashlib: 2 min 21 sec
  • test_gdb: 1 min 48 sec

1 test altered the execution environment:
test_concurrent_futures

19 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_idle
test_ioctl test_kqueue test_launcher test_perf_profiler
test_startfile test_tcl test_tkinter test_ttk test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

Total duration: 36 min 13 sec

Click to see traceback logs
remote: Enumerating objects: 11, done.        
remote: Counting objects:   9% (1/11)        
remote: Counting objects:  18% (2/11)        
remote: Counting objects:  27% (3/11)        
remote: Counting objects:  36% (4/11)        
remote: Counting objects:  45% (5/11)        
remote: Counting objects:  54% (6/11)        
remote: Counting objects:  63% (7/11)        
remote: Counting objects:  72% (8/11)        
remote: Counting objects:  81% (9/11)        
remote: Counting objects:  90% (10/11)        
remote: Counting objects: 100% (11/11)        
remote: Counting objects: 100% (11/11), done.        
remote: Compressing objects:  20% (1/5)        
remote: Compressing objects:  40% (2/5)        
remote: Compressing objects:  60% (3/5)        
remote: Compressing objects:  80% (4/5)        
remote: Compressing objects: 100% (5/5)        
remote: Compressing objects: 100% (5/5), done.        
remote: Total 6 (delta 5), reused 1 (delta 1), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '7f55f58b6c97306da350f5b441d26f859e9d8f16'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 7f55f58b6c gh-106656: Remove --emit-line-directives from regen-cases (#106657)
Switched to and reset branch 'main'

./Modules/_testcapi/heaptype_relative.c: In function ‘make_sized_heaptypes’:
./Modules/_testcapi/heaptype_relative.c:62:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   62 |                            (unsigned long long)data_ptr,
      |                            ^

make: *** [Makefile:2018: buildbottest] Error 3

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux TraceRefs 3.x has failed when building commit 7f55f58.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/484/builds/3652) and take a look at the build logs.
  4. Check if the failure is related to this commit (7f55f58) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/484/builds/3652

Failed tests:

  • test__xxsubinterpreters
  • test_capi

Summary of the results of the build (if available):

==

Click to see traceback logs
remote: Enumerating objects: 31, done.        
remote: Counting objects:   3% (1/31)        
remote: Counting objects:   6% (2/31)        
remote: Counting objects:   9% (3/31)        
remote: Counting objects:  12% (4/31)        
remote: Counting objects:  16% (5/31)        
remote: Counting objects:  19% (6/31)        
remote: Counting objects:  22% (7/31)        
remote: Counting objects:  25% (8/31)        
remote: Counting objects:  29% (9/31)        
remote: Counting objects:  32% (10/31)        
remote: Counting objects:  35% (11/31)        
remote: Counting objects:  38% (12/31)        
remote: Counting objects:  41% (13/31)        
remote: Counting objects:  45% (14/31)        
remote: Counting objects:  48% (15/31)        
remote: Counting objects:  51% (16/31)        
remote: Counting objects:  54% (17/31)        
remote: Counting objects:  58% (18/31)        
remote: Counting objects:  61% (19/31)        
remote: Counting objects:  64% (20/31)        
remote: Counting objects:  67% (21/31)        
remote: Counting objects:  70% (22/31)        
remote: Counting objects:  74% (23/31)        
remote: Counting objects:  77% (24/31)        
remote: Counting objects:  80% (25/31)        
remote: Counting objects:  83% (26/31)        
remote: Counting objects:  87% (27/31)        
remote: Counting objects:  90% (28/31)        
remote: Counting objects:  93% (29/31)        
remote: Counting objects:  96% (30/31)        
remote: Counting objects: 100% (31/31)        
remote: Counting objects: 100% (31/31), done.        
remote: Compressing objects:   4% (1/24)        
remote: Compressing objects:   8% (2/24)        
remote: Compressing objects:  12% (3/24)        
remote: Compressing objects:  16% (4/24)        
remote: Compressing objects:  20% (5/24)        
remote: Compressing objects:  25% (6/24)        
remote: Compressing objects:  29% (7/24)        
remote: Compressing objects:  33% (8/24)        
remote: Compressing objects:  37% (9/24)        
remote: Compressing objects:  41% (10/24)        
remote: Compressing objects:  45% (11/24)        
remote: Compressing objects:  50% (12/24)        
remote: Compressing objects:  54% (13/24)        
remote: Compressing objects:  58% (14/24)        
remote: Compressing objects:  62% (15/24)        
remote: Compressing objects:  66% (16/24)        
remote: Compressing objects:  70% (17/24)        
remote: Compressing objects:  75% (18/24)        
remote: Compressing objects:  79% (19/24)        
remote: Compressing objects:  83% (20/24)        
remote: Compressing objects:  87% (21/24)        
remote: Compressing objects:  91% (22/24)        
remote: Compressing objects:  95% (23/24)        
remote: Compressing objects: 100% (24/24)        
remote: Compressing objects: 100% (24/24), done.        
remote: Total 31 (delta 11), reused 11 (delta 7), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '7f55f58b6c97306da350f5b441d26f859e9d8f16'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 7f55f58b6c gh-106656: Remove --emit-line-directives from regen-cases (#106657)
Switched to and reset branch 'main'

Objects/object.c:2224: _Py_ForgetReference: Assertion failed: invalid object chain
Enable tracemalloc to get the memory block allocation traceback

object address  : 0x7f1dfc319760
object refcount : 0
object type     : 0x5652ba1b08c0
object type name: bytes
object repr     : <refcnt 0 at 0x7f1dfc319760>

Fatal Python error: _PyObject_AssertFailed: _PyObject_AssertFailed
Python runtime state: initialized

Current thread 0x00007f1e06366740 (most recent call first):
  <no Python frame>

Extension modules: _xxsubinterpreters (total: 1)
Debug memory block at address p=0x7f1e0628dce0: API '�'
    18302063728033390045 bytes originally requested
    The 7 pad bytes at p-7 are not all FORBIDDENBYTE (0xfd):
        at p-7: 0xdd *** OUCH
        at p-6: 0xdd *** OUCH
        at p-5: 0xdd *** OUCH
        at p-4: 0xdd *** OUCH
        at p-3: 0xdd *** OUCH
        at p-2: 0xdd *** OUCH
        at p-1: 0xdd *** OUCH
    Because memory is corrupted at the start, the count of bytes requested
       may be bogus, and checking the trailing pad bytes may segfault.
    The 8 pad bytes at tail=0xfdfe7d1c0426babd are Fatal Python error: Segmentation fault

Current thread 0x00007f1e06366740 (most recent call first):
  <no Python frame>

Extension modules: _testcapi, _testmultiphase, _testsinglephase, _xxsubinterpreters, _testinternalcapi (total: 5)
make: *** [Makefile:2022: buildbottest] Segmentation fault (core dumped)

Cannot open file '/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/test-results.xml' for upload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's not generate #line directives in generated_cases.c.h
2 participants