gh-106242: Fix path truncation in normpath #106816
Conversation
|
Looks like we just need the NEWS entry - click "Details" next to the failed check for info on it (or run Text should be something like ``Fixes :func: |
Misc/NEWS.d/next/Library/2023-08-14-23-11-11.gh-issue-106242.71HMym.rst
Outdated
Show resolved
Hide resolved
…1HMym.rst Co-authored-by: Steve Dower <[email protected]>
zooba
added
needs backport to 3.11
|
Sorry, @finnagin and @zooba, I could not cleanly backport this to |
|
Sorry, @finnagin and @zooba, I could not cleanly backport this to |
|
GH-107981 is a backport of this pull request to the 3.12 branch. |
|
GH-107982 is a backport of this pull request to the 3.11 branch. |
…#107982) Co-authored-by: Finn Womack <[email protected]>
…#107981) * gh-106242: Fix path truncation in os.path.normpath (GH-106816) * gh-106242: Minor fixup to avoid compiler warnings --------- Co-authored-by: Finn Womack <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
Following the suggestion from this comment in the original issue this PR adds a new function
_Py_normpathAndSizewhich behaves like_Py_normpathbut also takes a pointer which it will use to store the length of the final normalized path. This new function is then used inos__path_normpath_implto pass the above mentioned length intoPyUnicode_FromWideCharinstead of -1.Additionally, this adds a test to check that normpath is not truncating paths containing a null character as well as changes
test_addpackage_import_bad_pth_fileintest_site.pywhich was using a null character to make a bad path, specifically it was using the string'abc\x00def'. The problem is that before this change this was being truncated for parts of the test so the string it was actually using in those parts was'abc'. Upon making the normpath changes it started throwing the errorValueError: embedded null characterso I changed the test to use'abc<>$$**:://def'instead.