Skip to content

Docs: Argument Clinic: Restructure "Basic concepts and usage" #106981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 26, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 21, 2023

Split "Basic concepts and usage" into:

  • Reference

    • Terminology
    • CLI reference
  • Background

    • Basic concepts

📚 Documentation preview 📚: https://cpython-previews--106981.org.readthedocs.build/

Split "Basic concepts and usage" into:

- Reference
  - Terminology
  - CLI reference

- Background
  - Basic concepts
@erlend-aasland
Copy link
Contributor Author

I'm not quite satisfied with this yet, but I'm throwing it out now, to have some more eyes on it. Hopefully, this is a step in the right direction.

I considered making the "Basic usage" thing the introduction; that is, no title, no section; just a plain introduction just after the abstract. Perhaps that is an idea to follow.

Anyways, I think it makes sense to create a reference section and put the CLI usage and terminology there. On a longer term, we'll probably also fill it up with stuff like the CConverter class.

@erlend-aasland
Copy link
Contributor Author

Thanks for the reviews! Does the overall change make sense to you?

@erlend-aasland
Copy link
Contributor Author

@AlexWaygood, are you interested in reviewing this?

@erlend-aasland
Copy link
Contributor Author

@AlexWaygood, are you ok with the last changes?

@erlend-aasland
Copy link
Contributor Author

I'm landing this now; there'll be plenty of time for docs tweaks later :)

@erlend-aasland
Copy link
Contributor Author

Thanks for the valuable reviews, everyone!

@erlend-aasland erlend-aasland enabled auto-merge (squash) July 26, 2023 21:24
@erlend-aasland erlend-aasland merged commit 2ad6990 into python:main Jul 26, 2023
@erlend-aasland erlend-aasland deleted the clinic-docs/reference branch July 26, 2023 22:36
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 26, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2ad699002e3ce09e9fa41e333ac72f16a32d94de 3.11

@bedevere-bot
Copy link

GH-107325 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 26, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2023
…GH-106981)

Split "Basic concepts and usage" into:

- Reference
  - Terminology
  - CLI reference

- Background
  - Basic concepts

(cherry picked from commit 2ad6990)

Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
@bedevere-bot
Copy link

GH-107327 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 26, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 26, 2023
…ython#106981)

Split "Basic concepts and usage" into:

- Reference
  - Terminology
  - CLI reference

- Background
  - Basic concepts

(cherry picked from commit 2ad6990)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 26, 2023
…106981) (#107327)

Split "Basic concepts and usage" into:

- Reference
  - Terminology
  - CLI reference

- Background
  - Basic concepts

(cherry picked from commit 2ad6990)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
…#106981)

Split "Basic concepts and usage" into:

- Reference
  - Terminology
  - CLI reference

- Background
  - Basic concepts

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 27, 2023
…H-106981) (#107325)

Split "Basic concepts and usage" into:

- Reference
  - Terminology
  - CLI reference

- Background
  - Basic concepts

(cherry picked from commit 2ad6990)

Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
erlend-aasland added a commit to erlend-aasland/devguide that referenced this pull request Sep 8, 2023
…/cpython#106981)

Split "Basic concepts and usage" into:

- Reference
  - Terminology
  - CLI reference

- Background
  - Basic concepts

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
AA-Turner added a commit to AA-Turner/devguide that referenced this pull request Sep 13, 2023
…/cpython#106981)

Split "Basic concepts and usage" into:

- Reference
  - Terminology
  - CLI reference

- Background
  - Basic concepts

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
erlend-aasland added a commit to python/devguide that referenced this pull request Sep 26, 2023
…/cpython#106981)

Split "Basic concepts and usage" into:

- Reference
  - Terminology
  - CLI reference

- Background
  - Basic concepts

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants