-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-107432 Fix incorrect indentation in annotations HOWTO #107445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Body text in https://docs.python.org/3/howto/annotations.html was indented throughout, and was being rendered in blockquote elements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good, and I think we should merge it. However, it's pretty unfortunate for git blame
that this touches nearly every line in the file.
I wonder if we should add a .git-blame-ignore-revs
file to CPython. After this is merged, perhaps we could add the commit to that file, so that digging through git blame
is easier for future contributors. Curious if others have any thoughts on this.
I think it's a good idea. This change is an improvement and, given that we have a mechanism to avoid the issues this could cause to git blame (which, IIUC, is the main issue this would cause), we should utilize that mechanism. |
I've asked on the Core Dev discord if there are any objections to adding a |
There was support and no objections, and it should be mentioned in the devguide. |
GH-107654 is a backport of this pull request to the 3.12 branch. |
GH-107655 is a backport of this pull request to the 3.11 branch. |
…nGH-107445) pythongh-107432 Fix incorrect indentation in annotations document Body text in https://docs.python.org/3/howto/annotations.html was indented throughout, and was being rendered in blockquote elements. (cherry picked from commit 5e2746d) Co-authored-by: Daniele Procida <[email protected]>
…nGH-107445) pythongh-107432 Fix incorrect indentation in annotations document Body text in https://docs.python.org/3/howto/annotations.html was indented throughout, and was being rendered in blockquote elements. (cherry picked from commit 5e2746d) Co-authored-by: Daniele Procida <[email protected]>
…07445) (#107655) gh-107432 Fix incorrect indentation in annotations HOWTO (GH-107445) gh-107432 Fix incorrect indentation in annotations document Body text in https://docs.python.org/3/howto/annotations.html was indented throughout, and was being rendered in blockquote elements. (cherry picked from commit 5e2746d) Co-authored-by: Daniele Procida <[email protected]>
…07445) (#107654) gh-107432 Fix incorrect indentation in annotations HOWTO (GH-107445) gh-107432 Fix incorrect indentation in annotations document Body text in https://docs.python.org/3/howto/annotations.html was indented throughout, and was being rendered in blockquote elements. (cherry picked from commit 5e2746d) Co-authored-by: Daniele Procida <[email protected]>
Body text in https://docs.python.org/3/howto/annotations.html was indented throughout, and was being rendered in blockquote elements.
📚 Documentation preview 📚: https://cpython-previews--107445.org.readthedocs.build/