Skip to content

gh-104683: Rework Argument Clinic error handling #107551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Aug 3, 2023
Merged

gh-104683: Rework Argument Clinic error handling #107551

Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
36bac55
Rework error handling
erlend-aasland Jul 29, 2023
9cb2ce9
Merge branch 'main' into clinic/warn-and-fail
erlend-aasland Jul 31, 2023
789f5ee
Adapt new test
erlend-aasland Jul 31, 2023
15a246b
Pull in main
erlend-aasland Aug 1, 2023
e32d221
Pull in main
erlend-aasland Aug 1, 2023
4350ecc
Align with Alex's changes
erlend-aasland Aug 1, 2023
ad5181a
Address review: pass iso. ellipse
erlend-aasland Aug 1, 2023
545e7b6
Address review: add return annotation
erlend-aasland Aug 1, 2023
c978a6d
Address review: re.escape
erlend-aasland Aug 1, 2023
33b038c
Address review: fix test
erlend-aasland Aug 1, 2023
7b631a3
Refactor: extract method parse_parameter_name()
erlend-aasland Aug 1, 2023
553cb6e
Address review: re.escape better
erlend-aasland Aug 2, 2023
1514f63
Address review: UserWarning iso. Warning
erlend-aasland Aug 2, 2023
d3daef7
Revert "Refactor: extract method parse_parameter_name()"
erlend-aasland Aug 2, 2023
aa38570
Pull in main
erlend-aasland Aug 2, 2023
8f3750b
Print debug stuff to stderr
AlexWaygood Aug 2, 2023
e8b8d7e
Adapt test
erlend-aasland Aug 2, 2023
79b9859
Print to stdout instead of using warnings.warn
erlend-aasland Aug 2, 2023
57eff9d
Final touches
erlend-aasland Aug 2, 2023
5b8dea9
Pull in main
erlend-aasland Aug 2, 2023
6f5cfae
Fix merge
erlend-aasland Aug 2, 2023
3081729
Try to produce correct line numbers in error messages
erlend-aasland Aug 2, 2023
716bda8
Fixup CLI error formatting
erlend-aasland Aug 2, 2023
af79481
Fix reraise of ClinicError in parse()
erlend-aasland Aug 2, 2023
d109b63
Adjust tests again
erlend-aasland Aug 2, 2023
ecbfe2c
Remove unused import
erlend-aasland Aug 2, 2023
90e1bc9
Mutate the exception
erlend-aasland Aug 2, 2023
7766c3d
Share more code between the `warn()` and `fail()` branches (#49)
AlexWaygood Aug 2, 2023
3d9d6c6
Pull in main
erlend-aasland Aug 2, 2023
8573928
Pull in main
erlend-aasland Aug 2, 2023
fcd4721
Add docstring to _expect_failure
erlend-aasland Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading