Docs: Only include Plausible for html, not for epub etc #107637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
added
needs backport to 3.11
Mariatta
approved these changes
Aug 4, 2023
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-107642 is a backport of this pull request to the 3.12 branch. |
|
GH-107643 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 4, 2023
) Only include Plausible for html, not for epub etc (cherry picked from commit 904b531) Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 4, 2023
) Only include Plausible for html, not for epub etc (cherry picked from commit 904b531) Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
added a commit
that referenced
this pull request
Aug 4, 2023
…7637) (#107643) Co-authored-by: Hugo van Kemenade <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 4, 2023
…7637) (#107642) Docs: Only include Plausible for html, not for epub etc (GH-107637) Only include Plausible for html, not for epub etc (cherry picked from commit 904b531) Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes report at:
https://mail.python.org/archives/list/[email protected]/thread/HSIILYH7LVK4JU5U5GWHHIP4PU34UTNN/
Screenshot
We only need to include the Plausible metrics tags for the HTML build, not for epub etc. builds.
To test:
Before:
make -C Doc htmlview, view source and confirm<script defer data-domain="docs.python.org" src="https://plausible.io/js/script.js"></script>is presentmake -C Doc epub, openDoc/build/epub/Python.epubin an app such as Books on Mac -> error shownAfter:
📚 Documentation preview 📚: https://cpython-previews--107637.org.readthedocs.build/