Skip to content

Docs: Argument Clinic: Move the CConverter class to the reference #107671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 5, 2023


.. module:: clinic

.. class:: CConverter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an actual class that I can import and use? If not, should it get a :noindex:?

I was going through the howto and saw an example that points to Modules/zlibmodule.c, but in the source there's no mention of CConverter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must subclass the CConverter class when you write custom converters. Perhaps we can point to Modules/posixmodule.c instead; there's a lot of custom converters there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answering your first question; you cannot import it, but you can use it. It is "magically" there when you write a [python input] block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the :noindex:, though.

@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the clinic-docs/reference-cconverter branch August 7, 2023 00:08
@bedevere-bot
Copy link

GH-107701 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 7, 2023
@bedevere-bot
Copy link

GH-107702 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 7, 2023
erlend-aasland added a commit that referenced this pull request Aug 7, 2023
…nce (GH-107671) (#107702)

(cherry picked from commit a6675b1)

Co-authored-by: Erlend E. Aasland <[email protected]>
kostyafarber pushed a commit to kostyafarber/cpython that referenced this pull request Aug 7, 2023
Yhg1s pushed a commit that referenced this pull request Aug 7, 2023
…nce (GH-107671) (#107701)

Docs: Argument Clinic: Move the CConverter class to the reference (GH-107671)
(cherry picked from commit a6675b1)

Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants