gh-107877: Update logging levels reference table with usage criteria. #107894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
Aug 12, 2023
There was a problem hiding this comment.
You could consider converting the table into a list-table, like we use in the typing docs here:
cpython/Doc/library/typing.rst
Line 3693 in 2e1f688
It might make it easier to maintain it
There was a problem hiding this comment.
Thanks for the suggestion - perhaps not worth changing it again now for this specific instance, but I'll bear in mind when creating tables in future!
AlexWaygood
reviewed
Aug 12, 2023
Co-authored-by: Alex Waygood <[email protected]>
vsajip
added
needs backport to 3.11
|
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-107921 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 13, 2023
…teria. (pythonGH-107894) (cherry picked from commit cc2cf85) Co-authored-by: Vinay Sajip <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
|
GH-107922 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 13, 2023
…teria. (pythonGH-107894) (cherry picked from commit cc2cf85) Co-authored-by: Vinay Sajip <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 14, 2023
…iteria. (GH-107894) (#107922) gh-107877: Update logging levels reference table with usage criteria. (GH-107894) (cherry picked from commit cc2cf85) Co-authored-by: Vinay Sajip <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loggingdebug levels is unclear #107877📚 Documentation preview 📚: https://cpython-previews--107894.org.readthedocs.build/