gh-107924: re-order os.sendfile() flag documentation #107926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
calestyo
force-pushed
the
improve-os-doc
branch
from
96f3c94 to
1577f68
Compare
|
Updated the first commit. I've saw that the introducing text also names the various file types and I hadn't added |
AA-Turner
reviewed
Aug 14, 2023
Signed-off-by: Christoph Anton Mitterer <[email protected]>
calestyo
force-pushed
the
improve-os-doc
branch
from
1577f68 to
0d3b527
Compare
calestyo
changed the title
AA-Turner
reviewed
Aug 15, 2023
AA-Turner
approved these changes
Aug 21, 2023
AA-Turner
added
awaiting review
needs backport to 3.11
|
Note: will need manual backport for 3.11. A |
|
Shall I do the backport? And is it even necessary at all? I mean it's just a cosmetic ordering. |
hugovk
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Thanks!
Yes, it would be good if you could do the backport for 3.11.
Two reasons:
- The 3.11 docs are the ones served at https://docs.python.org/3/, we want people to see this fix
- If we don't backport this, but then backport another fix, we can end up with merge conflicts. It's usually easier to keep them in sync.
|
Sorry, @calestyo and @hugovk, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2023
…107926) (cherry picked from commit 403ab13) Co-authored-by: Christoph Anton Mitterer <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
GH-109099 is a backport of this pull request to the 3.12 branch. |
Yhg1s
pushed a commit
that referenced
this pull request
Sep 8, 2023
… (#109099) gh-107924: re-order os.sendfile() flag documentation (GH-107926) (cherry picked from commit 403ab13) Co-authored-by: Christoph Anton Mitterer <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
GH-109178 is a backport of this pull request to the 3.11 branch. |
hugovk
added a commit
to hugovk/cpython
that referenced
this pull request
Sep 9, 2023
…7926) Co-authored-by: Hugo van Kemenade <[email protected]> (cherry picked from commit 403ab13)
hugovk
added a commit
that referenced
this pull request
Sep 9, 2023
…#109178) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Christoph Anton Mitterer <[email protected]>
|
I did the 3.11 backport, thanks again for the issue and fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #107924. I didn't merge the two flag sections as mentioned there, cause the one for
SF_NOCACHEhas some extra description, and merging that would also be ugly, I guess.Cheers,
Chris.
📚 Documentation preview 📚: https://cpython-previews--107926.org.readthedocs.build/