Skip to content

Docs, sys.unraisablehook: emphasize warning and add accurate markups #108105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 18, 2023

@erlend-aasland
Copy link
Contributor Author

Check the docs preview for how it looks in real life.

@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 18, 2023
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the docs/unraisable branch August 18, 2023 10:16
@bedevere-bot
Copy link

GH-108109 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 18, 2023
@erlend-aasland
Copy link
Contributor Author

Thanks for the review, Victor :)

@bedevere-bot
Copy link

GH-108110 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 18, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2023
erlend-aasland added a commit that referenced this pull request Aug 18, 2023
…sablehook (GH-108105) (#108110)

(cherry picked from commit cc58ec9)

Co-authored-by: Erlend E. Aasland <[email protected]>
Yhg1s pushed a commit that referenced this pull request Aug 18, 2023
…sablehook (GH-108105) (#108109)

Docs: emphasise warning and add accurate markups for sys.unraisablehook (GH-108105)
(cherry picked from commit cc58ec9)

Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants