-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-108617: Extend interactive session tests for sqlite3 #108556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-108617: Extend interactive session tests for sqlite3 #108556
Conversation
serhiy-storchaka
commented
Aug 28, 2023
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Extend sqlite3 CLI tests #108617
Thanks, this is very nice. Are you ok with landing #108551 first? Either way, one of the PRs will have to resolve conflicts. |
If it is compatible with #108551. But since it only calls |
On other hand, if the CLI outputs some farewell message, there will be conflicts. Also, #108551 does not test that all output is not hold until the program ends. In case of some issues I will need to partially revert your changes and simulate a subprocess with a thread. |
OTOH, we're simply testing the underlying |
Good use of the |
There's a new commit after the PR has been approved. @erlend-aasland: please review the changes made to this pull request. |
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
GH-108626 is a backport of this pull request to the 3.12 branch. |
…GH-108556) (cherry picked from commit ecb2bf0) Co-authored-by: Serhiy Storchaka <[email protected]>