Skip to content

gh-108550: Fix sqlite3 CLI regression from gh-108551 #108618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2023
Merged

gh-108550: Fix sqlite3 CLI regression from gh-108551 #108618

merged 1 commit into from
Aug 29, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 29, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Aug 29, 2023
Closed
@erlend-aasland erlend-aasland enabled auto-merge (squash) August 29, 2023 08:59
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Aug 29, 2023 •
edited
Loading

The tests did not catch this, since they directly invoke main().

@erlend-aasland erlend-aasland merged commit c884784 into python:main Aug 29, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2023
@erlend-aasland @miss-islington
pythongh-108550: Fix sqlite3 CLI regression from pythongh-108551 (pyt…
a9af6fe 
…honGH-108618)

(cherry picked from commit c884784)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot
Copy link

GH-108621 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 29, 2023
@erlend-aasland erlend-aasland deleted the sqlite/fix-gh-108551 branch August 29, 2023 10:13
Yhg1s pushed a commit that referenced this pull request Aug 29, 2023
@miss-islington @erlend-aasland
[3.12] gh-108550: Fix sqlite3 CLI regression from gh-108551 (GH-108618)…
cdca4af 
… (#108621)

gh-108550: Fix sqlite3 CLI regression from gh-108551 (GH-108618)
(cherry picked from commit c884784)

Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @miss-islington @bedevere-bot