gh-108717: Speedup os.DirEntry.is_junction function
#108718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
approved these changes
Aug 31, 2023
|
@erlend-aasland do you want to wait for other opinions as well before merging? :) |
Since you requested reviews from @eryksun and @barneygale, I thought it would be nice to give them a chance to review before landing :) |
serhiy-storchaka
approved these changes
Sep 5, 2023
barneygale
approved these changes
Sep 5, 2023
|
@sobolevn, can you fix the conflicts (probably just a regen clinic)? |
kumaraditya303
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #99548
os.DirEntry.is_junctioncan be ~twice as fast #108717