Skip to content

Fix test_regrtest when run with uops always on #108778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Sep 1, 2023

The fix has two parts:

  • When -X uops is detected, pass it on to the subprocess created to run the manufactured test.
    I need this so I can run ./python -Xuops -m test test_regrtest and see it fail without the next fix.
  • Use -R 6:3: in ArgsTestCase.test_huntrleaks instead of -R 3:3: -- it takes longer to settle with -X uops.

(This is an attempt to make gh-107820 pass all tests. The other failure there is an failing assertion in test_exceptions, but I believe that's fixed by gh-108725.)

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Sep 1, 2023
@gvanrossum
Copy link
Member Author

Just gonna merge.

@gvanrossum gvanrossum marked this pull request as ready for review September 1, 2023 23:25
@gvanrossum gvanrossum merged commit 76ce537 into python:main Sep 1, 2023
@gvanrossum gvanrossum deleted the pass-uops branch September 1, 2023 23:27
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO 3.x has failed when building commit 76ce537.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/567/builds/4797) and take a look at the build logs.
  4. Check if the failure is related to this commit (76ce537) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/567/builds/4797

Summary of the results of the build (if available):

Click to see traceback logs
remote: Enumerating objects: 9, done.        
remote: Counting objects:  11% (1/9)        
remote: Counting objects:  22% (2/9)        
remote: Counting objects:  33% (3/9)        
remote: Counting objects:  44% (4/9)        
remote: Counting objects:  55% (5/9)        
remote: Counting objects:  66% (6/9)        
remote: Counting objects:  77% (7/9)        
remote: Counting objects:  88% (8/9)        
remote: Counting objects: 100% (9/9)        
remote: Counting objects: 100% (9/9), done.        
remote: Compressing objects:  20% (1/5)        
remote: Compressing objects:  40% (2/5)        
remote: Compressing objects:  60% (3/5)        
remote: Compressing objects:  80% (4/5)        
remote: Compressing objects: 100% (5/5)        
remote: Compressing objects: 100% (5/5), done.        
remote: Total 5 (delta 4), reused 0 (delta 0), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '76ce537fb1291f90c6dccbfea8653544de7902fd'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 76ce537fb1 Fix test_regrtest when run with uops always on (#108778)
Switched to and reset branch 'main'

lto-wrapper: fatal error: gcc returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make: *** [Makefile:1311: Programs/_freeze_module] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants