Skip to content

gh-109045: Remove remaining LIMITED_API_AVAILABLE checks in tests #109046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Sep 7, 2023

Commit 13a0007 (#108663) made all Python builds compatible with the Limited API, and removed the LIMITED_API_AVAILABLE flag. However, some tests were still checking for that flag, so they were now being incorrectly skipped. Remove these checks to let these tests run again.

Fixes #109045.

Commit 13a0007 (python#108663) made all
Python builds compatible with the Limited API, and removed the
LIMITED_API_AVAILABLE flag.  However, some tests were still checking
for that flag, so they were now being incorrectly skipped.  Remove
these checks to let these tests run again.

Signed-off-by: Anders Kaseorg <[email protected]>
@vstinner
Copy link
Member

vstinner commented Sep 7, 2023

Oops! I didn't know that the macro was used outside parts.h! Thanks for the fix.

@andersk andersk deleted the limited-api-available branch September 7, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limited API tests are now incorrectly skipped unconditionally
3 participants