Skip to content

gh-109234: Enhanced sqlite3 connection context management documentation with contextlib.closing #109322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Oct 3, 2023
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
73b39d3
Enhanced sqlite3 connection context management documentation with con…
Lincoln-developer Sep 12, 2023
0ece8fb
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 13, 2023
89aef42
Fixed gitignore spelling error from nitignore to gitignore
Lincoln-developer Sep 13, 2023
70177cc
Merge branch 'fix-issue-109234' of https://github.com/Lincoln-develop…
Lincoln-developer Sep 13, 2023
b8eeab6
Renamed .gitignore to .nitignore
Lincoln-developer Sep 13, 2023
93341b3
Merge branch 'main' into fix-issue-109234
Lincoln-developer Sep 13, 2023
164150c
Added generated doctests
Lincoln-developer Sep 13, 2023
adba2f7
Merge branch 'fix-issue-109234' of https://github.com/Lincoln-develop…
Lincoln-developer Sep 13, 2023
dd107f7
Deleted sqlite3 generated files
Lincoln-developer Sep 13, 2023
98c4491
Merge branch 'main' into fix-issue-109234
Lincoln-developer Sep 14, 2023
a4b6faa
Removed white-space changes
Lincoln-developer Sep 18, 2023
24aeefe
Merge branch 'fix-issue-109234' of https://github.com/Lincoln-develop…
Lincoln-developer Sep 18, 2023
e4d6417
Removed News entry from the doc
Lincoln-developer Sep 18, 2023
f51cad8
Expanded a note that context manager can be used for connection manag…
Lincoln-developer Sep 18, 2023
cab833b
Removed repeated contextlib.closing code snippet
Lincoln-developer Sep 18, 2023
4a6d7e7
Expanded the note around usage of context manageer for sqlite3 connec…
Lincoln-developer Sep 18, 2023
19327a2
Deleted extra white-spaces
Lincoln-developer Sep 18, 2023
df79d4b
Deleted extra white-space
Lincoln-developer Sep 18, 2023
a5509cf
re-arranged context manager wording
Lincoln-developer Sep 18, 2023
539d6f8
Merge branch 'main' into fix-issue-109234
Lincoln-developer Sep 19, 2023
ce189a9
Merge branch 'fix-issue-109234' of https://github.com/Lincoln-develop…
Lincoln-developer Sep 18, 2023
db52bd0
Merge branch 'main' into fix-issue-109234
Lincoln-developer Sep 19, 2023
f140098
Re-arranged word layout on how to use context manager
Lincoln-developer Sep 20, 2023
58ba8d0
Pull in main
erlend-aasland Sep 28, 2023
9ede06a
Fix whitespace errors
erlend-aasland Sep 28, 2023
57d92ad
Remove unneeded change in .gitignore
erlend-aasland Sep 28, 2023
4210fe9
Added suggested changes
Lincoln-developer Sep 29, 2023
c7f1233
added suggested changes
Lincoln-developer Sep 29, 2023
d660c42
Added suggested change redirecting to the contextlib.closing implemen…
Lincoln-developer Oct 2, 2023
54992fa
Merge branch 'main' into fix-issue-109234
Lincoln-developer Oct 2, 2023
3db6b3b
Merge branch 'fix-issue-109234' of https://github.com/Lincoln-develop…
Lincoln-developer Oct 2, 2023
fe11167
Merge branch 'main' into fix-issue-109234
Lincoln-developer Oct 2, 2023
7fc06d1
Added closing keyword
Lincoln-developer Oct 3, 2023
a79e330
Merge branch 'fix-issue-109234' of https://github.com/Lincoln-develop…
Lincoln-developer Oct 3, 2023
52ccdad
Removed line 2473
Lincoln-developer Oct 3, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Doc/library/sqlite3.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2437,9 +2437,9 @@ or if :attr:`~Connection.autocommit` is ``True``,
the context manager does nothing.

.. note::

The context manager neither implicitly opens a new transaction
nor closes the connection.
nor closes the connection. If you need a closing context manager, consider
using :meth:`contextlib.closing`.

.. testcode::

Expand Down