Skip to content

gh-109413 Improve the mypy config file for libregrtest #109518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 9 additions & 23 deletions Lib/test/libregrtest/mypy.ini
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
# Config file for running mypy on libregrtest.
#
# Note: mypy can't be run on libregrtest from the CPython repo root.
# If you try to do so, mypy will complain
# about the entire `Lib/` directory "shadowing the stdlib".
# Instead, `cd` into `Lib/test`, then run `mypy --config-file libregrtest/mypy.ini`.
# Run mypy by invoking `mypy --config-file Lib/test/libregrtest/mypy.ini`
# on the command-line from the repo root

[mypy]
packages = libregrtest
files = Lib/test/libregrtest
explicit_package_bases = True
python_version = 3.11
platform = linux
pretty = True
Expand All @@ -17,7 +15,6 @@ strict = True

# Various stricter settings that we can't yet enable
# Try to enable these in the following order:
strict_optional = False
disallow_any_generics = False
disallow_incomplete_defs = False
disallow_untyped_calls = False
Expand All @@ -27,21 +24,10 @@ warn_return_any = False

disable_error_code = return

# Various internal modules that typeshed deliberately doesn't have stubs for:
[mypy-_abc.*]
ignore_missing_imports = True

[mypy-_opcode.*]
ignore_missing_imports = True

[mypy-_overlapped.*]
ignore_missing_imports = True

[mypy-_testcapi.*]
ignore_missing_imports = True

[mypy-_testinternalcapi.*]
ignore_missing_imports = True
# Enable --strict-optional for these ASAP:
[mypy-Lib.test.libregrtest.main.*,Lib.test.libregrtest.run_workers.*,Lib.test.libregrtest.worker.*,Lib.test.libregrtest.single.*,Lib.test.libregrtest.results.*,Lib.test.libregrtest.utils.*]
strict_optional = False

[mypy-test.*]
# Various internal modules that typeshed deliberately doesn't have stubs for:
[mypy-_abc.*,_opcode.*,_overlapped.*,_testcapi.*,_testinternalcapi.*,test.*]
ignore_missing_imports = True