Skip to content

Docs: bump Pygments to fix contrast ratios to meet WCAG AA guidelines #110208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 2, 2023

Already updated in Doc/requirements-oldest-sphinx.txt, used for testing on the CI.

Let's also allow it for the real docs, so we can include the dark mode contrast fixed by pygments/pygments#2448 in Pygments 2.16.

For example:

Before

image

After

image

📚 Documentation preview 📚: https://cpython-previews--110208.org.readthedocs.build/

@AA-Turner AA-Turner added the docs Documentation in the Doc dir label Oct 2, 2023
@hugovk hugovk merged commit 9cb8927 into python:main Oct 2, 2023
@hugovk hugovk deleted the bump-pygments branch October 2, 2023 10:31
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 2, 2023

GH-110210 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 2, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 2, 2023

GH-110211 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 2, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2023
hugovk added a commit that referenced this pull request Oct 2, 2023
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
…delines (GH-110208) (#110210)

Docs: bump Pygments to fix contrast ratios to meet WCAG AA guidelines (GH-110208)
(cherry picked from commit 9cb8927)

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants