Skip to content

[3.12] gh-109234: Hint to contextlib.closing in sqlite3 context manager docs (GH-109322) #110294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 3, 2023

(cherry picked from commit 4227bfa)

Co-authored-by: Lincoln [email protected]
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland [email protected]


📚 Documentation preview 📚: https://cpython-previews--110294.org.readthedocs.build/

…textlib.closing pythongh-109234 (pythonGH-109322)

* Enhanced sqlite3 connection context management documentation with contextlib.closing

* 📜🤖 Added by blurb_it.

* Fixed gitignore spelling error from nitignore to gitignore

* Renamed .gitignore to .nitignore

* Added generated doctests

* Deleted sqlite3 generated files

* Removed white-space changes

* Removed News entry from the doc

* Expanded a note that context manager can be used for connection management using contextlib.closing

* Removed repeated contextlib.closing code snippet

* Expanded the note around usage of context manageer for sqlite3 connection management

* Deleted extra white-spaces

* Deleted extra white-space

* re-arranged context manager wording

* Re-arranged word layout on how to use context manager

* Fix whitespace errors

* Remove unneeded change in .gitignore

* Added suggested changes

* Added suggested change redirecting to the contextlib.closing implementation

* Added closing keyword

* Removed line 2473

---------

(cherry picked from commit 4227bfa)

Co-authored-by: Lincoln <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 3, 2023
@erlend-aasland erlend-aasland enabled auto-merge (squash) October 3, 2023 15:58
@erlend-aasland erlend-aasland changed the title [3.12] Enhanced sqlite3 connection context management documentation with contextlib.closing gh-109234 (GH-109322) [3.12] gh-109234: Hint to contextlib.closing in sqlite3 context manager docs (GH-109322) Oct 3, 2023
erlend-aasland added a commit that referenced this pull request Oct 3, 2023
…er docs (GH-109322) (#110294)

(cherry picked from commit 4227bfa)

Co-authored-by: Lincoln <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland erlend-aasland merged commit 90dea55 into python:3.12 Oct 3, 2023
@miss-islington miss-islington deleted the backport-4227bfa-3.12 branch October 3, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants