Don't doubly-parallelise sphinx-lint #110617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
added
docs
ezio-melotti
approved these changes
Oct 10, 2023
pradyunsg
approved these changes
Oct 10, 2023
AlexWaygood
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Nice! On my laptop this speeds things up from around 22 seconds to around 17 seconds. On @hugovk's, it went down from 5.5 seconds to around 3.4 seconds.
|
Thanks @AA-Turner for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2023
(cherry picked from commit e24f9ae) Co-authored-by: Adam Turner <[email protected]>
|
GH-110626 is a backport of this pull request to the 3.12 branch. |
|
GH-110627 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2023
(cherry picked from commit e24f9ae) Co-authored-by: Adam Turner <[email protected]>
hugovk
pushed a commit
that referenced
this pull request
Oct 10, 2023
Co-authored-by: Adam Turner <[email protected]>
hugovk
pushed a commit
that referenced
this pull request
Oct 10, 2023
Co-authored-by: Adam Turner <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx-Lint internally parallelises, and pre-commit also parallelises, leading to seeming resource contention. I observe a speed-up of ~5 seconds (from ~12 to ~7) when we let sphinx-lint control the parallelism.