gh-110686: Test pattern matching with runtime_checkable protocols
#110687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
Oct 12, 2023
|
Sorry, it took me quite a long time to address all review comments :) |
JelleZijlstra
approved these changes
Nov 4, 2023
|
Is there anything left to do? Or can you please merge it? :) |
|
I suppose I didn't merge to give @AlexWaygood some time to review it. Alex, any comments on this PR? If not, I think I'll merge it later today. |
|
Sorry for the slow response :( I'll try to take a look some time later today. If I haven't commented by tomorrow, feel free to merge |
|
Friendly ping |
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests will fail before #110682 is solved.
@runtime_checkableprotocols #110686