Skip to content

bpo-35452: Make PySys_HasWarnOptions() never raising an exception. #11075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 10, 2018

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have a minor suggestion.

Co-Authored-By: serhiy-storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka merged commit dffccc6 into python:master Dec 10, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the PySys_HasWarnOptions branch December 10, 2018 11:50
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2018
@bedevere-bot
Copy link

GH-11076 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants