Skip to content

gh-110774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase #110776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 31, 2023

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Oct 12, 2023

@graingert graingert changed the title allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase gh-10774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase Oct 12, 2023
@graingert graingert changed the title gh-10774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase gh-110774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase Oct 12, 2023
@graingert graingert force-pushed the unittest-loop-factory branch from 47669b3 to 0fbb894 Compare October 12, 2023 15:20
@graingert graingert marked this pull request as ready for review October 12, 2023 15:32
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @graingert. This looks good to me.

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks!

@gvanrossum gvanrossum merged commit 7705306 into python:main Oct 31, 2023
@graingert graingert deleted the unittest-loop-factory branch October 31, 2023 22:32
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
…atedAsyncioTestCase (python#110776)


Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…atedAsyncioTestCase (python#110776)


Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…atedAsyncioTestCase (python#110776)


Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants