[3.12] remove redundant call to attach_loop in watcher (GH-110847) #110867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5965891) Co-authored-by: Thomas Grainger <[email protected]>
miss-islington
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
gvanrossum
approved these changes
Oct 14, 2023
There was a problem hiding this comment.
Trusting @graingert’s assessment that those classes also define null implementations in 3.12.
|
ThreadedChildWatcher is here: cpython/Lib/asyncio/unix_events.py Lines 1408 to 1409 in 81a88fc PidfdChildWatcher is here: cpython/Lib/asyncio/unix_events.py Lines 943 to 944 in 81a88fc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 5965891)
Co-authored-by: Thomas Grainger [email protected]