gh-111673: Refactor test_float/complex.py (split out support classes) #110956
Conversation
Taken from python#26827 Co-authored-by: Sergey B Kirpichev <[email protected]>
skirpichev
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Yeah, we can skip it for this one, good call |
This comment was marked as outdated.
This comment was marked as outdated.
|
@sobolevn, maybe you can review this as an issue author? Let me know if it's better to split this to several pull requests. |
|
CC @vstinner |
There was a problem hiding this comment.
I'm not sure that I like this change. It changes a lot of tests for little value (it's just refactoring). But I'm not against this change.
@serhiy-storchaka: Do you have an opinion on this change?
| class FloatSubclass(float): | ||
| pass | ||
|
|
||
| class OtherFloatSubclass(float): |
There was a problem hiding this comment.
I'm not sure if it's worth it to have OtherFloatSubclass and OtherComplexSubclass in this number_helper module.
|
I already proposed something similar in #84310. But it only defined classes with a single special method ( |
|
Ok, thanks. I think, I haven't enough motivation to push it further. |
First commit mostly taken from #26827, second - some simple extension of this. @serhiy-storchaka