Skip to content

gh-111181: Fix enum doctests #111180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 22, 2023

Working on a full description of what is going on.

#111181


📚 Documentation preview 📚: https://cpython-previews--111180.org.readthedocs.build/

@sobolevn sobolevn changed the title Fix enum doctests gh-111181: Fix enum doctests Oct 22, 2023
@sobolevn
Copy link
Member Author

sobolevn commented Oct 22, 2023

@ethanfurman as I said I am not sure that my fixes are correct, I just want to show you that there are some broken tests at the moment. I need your help with the details :)

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 23, 2023
@ethanfurman
Copy link
Member

Thank you for getting the doc tests to always run. I'll work on getting the doc tests correct.

@ethanfurman ethanfurman self-assigned this Oct 23, 2023
@sobolevn sobolevn marked this pull request as ready for review October 28, 2023 06:03
@sobolevn sobolevn requested a review from ethanfurman as a code owner October 28, 2023 06:03
@ethanfurman ethanfurman merged commit c4dc5a6 into python:main Oct 30, 2023
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @sobolevn and @ethanfurman, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c4dc5a6ae8aa13abb743182df088f1a3526d1bcd 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 30, 2023
(cherry picked from commit c4dc5a6)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Ethan Furman <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 30, 2023

GH-111518 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 30, 2023
ethanfurman added a commit that referenced this pull request Oct 31, 2023
gh-111181: Fix enum doctests (GH-111180)
(cherry picked from commit c4dc5a6)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Ethan Furman <[email protected]>
ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Nov 1, 2023
Co-authored-by: Ethan Furman <[email protected]>
(cherry picked from commit c4dc5a6)
@bedevere-app
Copy link

bedevere-app bot commented Nov 1, 2023

GH-111617 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 1, 2023
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
ethanfurman added a commit that referenced this pull request Nov 3, 2023
gh-111181: Fix enum doctests (GH-111180)

Co-authored-by: Ethan Furman <[email protected]>
(cherry picked from commit c4dc5a6)

Co-authored-by: Nikita Sobolev <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants