Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-102980: Redirect pdb
interact
command, add tests and improve docs #111194New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-102980: Redirect pdb
interact
command, add tests and improve docs #111194Changes from all commits
f9b3123
4edbbc0
a56a294
4611d18
2eca91f
c3eb762
03e1dc0
cde8ecf
b4a14c6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this describing the code change in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. So currently
pdb
usescode.interact
directly forinteract
command. However,code.interact
has a hard-coded output tosys.stderr
.pdb
supports defining output channel, and we kind of use that for our tests. The user would also expect the output frominteract
command flushed to the same channel aspdb
(stdout instead of stderr by default actually).This PR subclassed
code.InteractiveConsole
to overwrite thewrite
method, in order to redirect the output toself.message
.