Skip to content

[3.12] gh-110395: invalidate open kqueues after fork (GH-110517) #111745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2023
Merged

[3.12] gh-110395: invalidate open kqueues after fork (GH-110517) #111745

merged 2 commits into from
Nov 11, 2023

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Nov 4, 2023 •
edited by bedevere-app bot
Loading

Invalidate open select.kqueue instances after fork as the fd will be invalid in the child. (cherry picked from commit a6c1c04)

@sorcio @gpshead
[3.12] pythongh-110395: invalidate open kqueues after fork (pythonGH-…
0b94952 
…110517)

Invalidate open select.kqueue instances after fork as the fd will be invalid in the child.
(cherry picked from commit a6c1c04)

Co-authored-by: Davide Rizzo <[email protected]>
@gpshead gpshead requested a review from rhettinger as a code owner November 4, 2023 23:04
This was referenced Nov 4, 2023
Closed
Merged
@gpshead gpshead requested review from vstinner and removed request for rhettinger November 4, 2023 23:04
vstinner
vstinner reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the change in main. I reviewed the change as if it was made in main. Feel free to ignore my review. If you care, issues should be addressed by main first.

vstinner
vstinner approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This time, I reviewed the backport itself, and it LGTM.

@gpshead gpshead merged commit 0f7671c into python:3.12 Nov 11, 2023
@gpshead gpshead deleted the backport-a6c1c04-3.12 branch November 11, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpshead @vstinner @sorcio