Skip to content

GH-111843: Tier 2 exponential backoff #111850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 9, 2023

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Nov 8, 2023

Use exponential backoff to reduce the number of failed optimization attempts in tier 2.

The stats show that tier 2 optimization is now 75% effective. Previously it was 0.2% effective.

@markshannon markshannon changed the title Tier 2 exponential backoff GH-111843: Tier 2 exponential backoff Nov 8, 2023
@@ -107,6 +107,7 @@ error_optimize(
_PyExecutorObject **exec,
int Py_UNUSED(stack_entries))
{
assert(0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member Author

@markshannon markshannon Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it aborts on debug builds. Release builds will raise a SystemError

@markshannon markshannon merged commit 34a03e9 into python:main Nov 9, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@markshannon markshannon deleted the tier-2-exponential-backoff branch August 6, 2024 10:17
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants