gh-111881: Use lazy import in doctest #111888
Conversation
Use lazy import for difflib and linecache imports in doctest to speedup Python startup and reduce the number of imports when running tests.
| @@ -1528,6 +1528,8 @@ def out(s): | |||
| self.debugger.reset() | |||
| pdb.set_trace = self.debugger.set_trace | |||
|
|
|||
| import linecache | |||
There was a problem hiding this comment.
Not sure there's much point in making this one a lazy import. How many times does someone import doctest and then not call this method? It's pretty core to the module's functionality, no?
If there are plausible, common situations where someone might import doctest but not call this method, it's worth it to make it a lazy import. But if it just gets imported anyway as soon as doctest is actually used, I think it would be better to continue importing it eagerly at the top of the module, as we're doing now.
There was a problem hiding this comment.
I wrote this change while trying hard to reduce the number of imports in libregrtest. Maybe #111884 makes this change less important.
I converted this PR as a draft for now. I will see how it goes with other changes to decide later if this change is "needed" or not.
|
I lost track of this change, so I just close it. |
Use lazy import for difflib and linecache imports in doctest to speedup Python startup and reduce the number of imports when running tests.