gh-111448: Make traceback.format_exception_only respect max_group_width and max_group_depth
#111952
+364
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
changed the title
limit_group parameter to traceback.format_exception_onlytraceback.format_exception_only respect max_group_width and max_group_depth
iritkatriel
reviewed
Nov 12, 2023
iritkatriel
reviewed
Nov 12, 2023
| yield from [indent + l + '\n' for l in note.split('\n')] | ||
| elif self.__notes__ is not None: | ||
| yield indent + "{}\n".format(_safe_string(self.__notes__, '__notes__', func=repr)) | ||
| limit = self.max_group_depth |
There was a problem hiding this comment.
it seems that there is a lot of repetition now between format and format_exception_only. Could we not have format take an arg to makes it skip the traceback (so that it becomes format_exception_only)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #104150
limit_groupoption totraceback.format_exception_only#111448📚 Documentation preview 📚: https://cpython-previews--111952.org.readthedocs.build/